refactor: consolidate ScopeMode logic into methods#765
Closed
DaleSeo wants to merge 2 commits into
Closed
Conversation
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 2b607460d64a5dcb5404f2d0 ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
DaleSeo
force-pushed
the
refactor/auth-cleanups
branch
from
8e8244a to
0c642f6
Compare
Contributor
|
❌ Changeset file missing for PR All changes should include an associated changeset file. |
Member
Author
|
Folded into #764 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the scope-sufficiency
matchout of theoauth_validatemiddleware and into aScopeMode::is_satisfied_bymethod. This change simplifies the middleware to a single condition. More importantly, it allows the scope-validation tests to call the actual method instead of a hand-copied version that could drift from production. It also updates thescope_modeheader rendering. Previously, it serialized the enum to JSON just to trim the quotes and included an unreachable"unknown"fallback. Now, it uses a straightforward and reliableScopeMode::as_str. A small guard test ensures thatas_strstays in sync with the serdesnake_caserename.